Subject: compilation errors: patched


Author: Sandeep, 2005-01-28 07:06:00
hi, to remove a few compilation errors in the compilation of inputmp4 plugin, you need to use the patches given below. The patch directory is, inputmp4/libmp4v2. The problem arises since virtual functions are initialised to NULL rather than to 0. The source code I used was lamip-inputMP4_20040823.tar.
Also, you need to used -fno-strict-aliasing to avoid aliasing errors.

The patches are
--- mp4property.h 2004-08-23 23:34:25.000000000 +0530
+++ /sss/my/player/lamip/inputmp4/libmp4v2/mp4property.h 2005-01-28 10:48:47.000000000 +0530
@@ -58,7 +58,7 @@
return m_name;
}

- virtual MP4PropertyType GetType() = NULL;
+ virtual MP4PropertyType GetType() =0;

bool IsReadOnly() {
return m_readOnly;
@@ -74,20 +74,20 @@
m_implicit = value;
}

- virtual u_int32_t GetCount() = NULL;
- virtual void SetCount(u_int32_t count) = NULL;
+ virtual u_int32_t GetCount() = 0;
+ virtual void SetCount(u_int32_t count) = 0;

virtual void Generate() { /* default is a no-op */ };

- virtual void Read(MP4File* pFile, u_int32_t index = 0) = NULL;
+ virtual void Read(MP4File* pFile, u_int32_t index = 0) = 0;

- virtual void Write(MP4File* pFile, u_int32_t index = 0) = NULL;
+ virtual void Write(MP4File* pFile, u_int32_t index = 0) = 0;

virtual void Dump(FILE* pFile, u_int8_t indent,
- bool dumpImplicits, u_int32_t index = 0) = NULL;
+ bool dumpImplicits, u_int32_t index = 0) = 0;

virtual bool FindProperty(const char* name,
- MP4Property** ppProperty, u_int32_t* pIndex = NULL);
+ MP4Property** ppProperty, u_int32_t* pIndex=NULL );

protected:
MP4Atom* m_pParentAtom;






--- rtphint.h 2004-08-23 23:34:25.000000000 +0530
+++ /sss/my/player/lamip/inputmp4/libmp4v2/rtphint.h 2005-01-28 10:47:56.000000000 +0530
@@ -35,8 +35,8 @@
return m_pPacket;
}

- virtual u_int16_t GetDataSize() = NULL;
- virtual void GetData(u_int8_t* pDest) = NULL;
+ virtual u_int16_t GetDataSize() = 0;
+ virtual void GetData(u_int8_t* pDest) = 0;

MP4Track* FindTrackFromRefIndex(u_int8_t refIndex);

Replies


Author: ciberfred, 2005-01-28 10:14:48
what is the compiler ? gcc 3.4.x ? :-)
Well i should upgrade the version of libmp4v2 to the newer one.
Remember that you could do it in dynamic way to compil this library that come from mpeg4ip project :)

Reply

Name : Email :